TWI Please Please Please Please Please PLEASE fix weapon priority. Come on now

[nutterbutter]

On any weapon key the priority should be

1) Perked weapon with ammo
2) Unperked weapon with ammo
3) Empty perked weapon
4) Empty unperked weapon

Ok, if that isn't possible, then the priority should be

1) PERKED weapon
2) Everything else

If I'm playing support, I shouldn't have to worry about '3' bringing up a grenade launcher before the shotgun.

 

[SHM]

AFAIK, the priority in the trader menu (that i suppose you're referring to) is:
1)Perked
2)Unperked

I can't see the point of this thread.

 

[|WC|Capt.525]

He's talking about weapon priority in you key binds. For example, when you press 4 as a Support, and if you are Carrying either a M14 or M32, they will come out before your Hunting Shotgun (good sometimes, bad if you forgot and the weapon isn't loaded).

 

[SHM]

Oh, sorry for that, I misjudged OP. Still, I'm fine with the current system, since I always reload a weapon before I switch to another. TWI needs to work on major bugs like dual pistols accuracy and invisible walls on Mac/Linux server, and then they can focus on these minors things.
My 2 cents

 

[poosh]

Prioritizing weapons by empty/non-empty isn't so easy. It would require to rebuild inventory chains every time weapon shot last ammo or ammo box is picked up. A lot of work and kindda useless. It is much easier to drop empty weapons on the ground and pick them up at the end of the wave.

But selecting perked weapons first is logical and would require only a couple of code lines to implement.

 

[becoming-insane]

Just curious, would it be difficult to implement a manual inventory organization?

Something like this: press <randomkey> to display your inventory cells and your mouse cursor on the screen. Then just drag&drop your weapons from cells to cells with your mouse, press <randomkey> again to apply the changes you've made.

 

[TheMutant]

Prioritizing weapons by empty/non-empty isn't so easy. It would require to rebuild inventory chains every time weapon shot last ammo or ammo box is picked up. A lot of work and kindda useless. It is much easier to drop empty weapons on the ground and pick them up at the end of the wave.

But selecting perked weapons first is logical and would require only a couple of code lines to implement.

Don't think that complicated. You should not rebuild the inventory at all, but a smart filter.
But indeed a bit of code is needed, as the inventory is an unsorted linked-list.
I created some code back then for TWI that improves it, but it needs a function that decides whether a weapon is perked or not first of all.

It is not perfect so far, some refinement might be needed:
- Only first weapon you switch to will definately be perked
- Perked weapons are handelled the same (M32 and M79 have same "weight")
+ Skips all empty weapons

Spoiler!

simulated function SwitchWeapon(byte F)
{
    local Weapon newWeapon;
    local Inventory inv;
    local class<KFVeterancyTypes> Veterancy;

    if ( (Level.Pauser!=None) || (Inventory == None) )
        return;

    //Use iterations instead of recursive calls -> faster, also it's better to filter out the best choice of weapon
    if ( Weapon != None )
    {
        Veterancy = KFPlayerReplicationInfo(PlayerReplicationInfo).ClientVeteranSkill;

        for ( inv=Weapon.Inventory; inv!=None; inv=inv.Inventory )  //Check weapons after current
        {
            if ( Weapon(inv) != None && inv.InventoryGroup == F && Weapon(inv).HasAmmo() )
            {
                //Pseudo code - prefer veterancy weapons, if player switches to a new inventory group.
                //IsVeterancyWeapon() is nowhere implemented, it returns true if weapon concerns to verterancytype of holder and false if not.
                //It could be implemented in class'KFVeterancyTypes'.
                if ( Weapon.InventoryGroup != F )
                {
                    if ( Veterancy.Static.IsVeterancyWeapon(Weapon(inv)) )  //first veterancy weapon after current
                    {
                        newWeapon = Weapon(inv);
                        break;
                    }
                    else if ( newWeapon == None )  //first non-verterancy weapon after current
                        newWeapon = Weapon(inv);
                }
                else
                {
                    newWeapon = Weapon(inv);
                    break;
                }
            }
        }

        if ( newWeapon == None )  //Check weapons before current
        {    
            for ( inv=Inventory; inv!=Weapon && inv!=None; inv=inv.Inventory )
            {
                if ( Weapon(inv) != None && inv.InventoryGroup == F && Weapon(inv).HasAmmo() )
                {
                    if ( Weapon.InventoryGroup != F )
                    {
                        if ( Veterancy.Static.IsVeterancyWeapon(Weapon(inv)) )  //first veterancy weapon after current
                        {
                            newWeapon = Weapon(inv);
                            break;
                        }
                        else if ( newWeapon == None )  //first non-verterancy weapon after current
                            newWeapon = Weapon(inv);
                    }
                    else
                    {
                        newWeapon = Weapon(inv);
                        break;
                    }
                }
            }
        }
    }

    if ( Weapon == None )
        newWeapon = Inventory.WeaponChange(F, true);
    else if ( newWeapon == None  )
    {
        if ( Weapon.HasAmmo() )
        {
            newWeapon = Weapon;

            if ( Weapon.InventoryGroup == F )
                ClientMessage( "Other weapons in group"@F@"are out of ammo!" );
            else
                ClientMessage( "All weapons in group"@F@"are out of ammo!" );
        }
    }

    if ( PendingWeapon != None && PendingWeapon.bForceSwitch )
        return;

    if ( Weapon == None )
    {
        PendingWeapon = newWeapon;
        ChangedWeapon();
    }
    else if ( Weapon != newWeapon || PendingWeapon != None )
    {
        PendingWeapon = newWeapon;
        Weapon.PutDown();
    }
    else if ( Weapon == newWeapon )
        Weapon.Reselect();
}

 

[Captain Howel]

Every dev's most hated phrase is "that shouldn't be too hard to implement."

Just curious, would it be difficult to implement a manual inventory organization?

Something like this: press <randomkey> to display your inventory cells and your mouse cursor on the screen. Then just drag&drop your weapons from cells to cells with your mouse, press <randomkey> again to apply the changes you've made.

Would it be difficult? Yes, since it requires an entirely new interface. It would also be a lot of item management to be doing in the middle of a game, much too distracting. But if it was to be done in the settings menu without having to be in a game to do it, that would be much more reasonable. On the other hand, the only way I can see this working is as a fan-made mutator, which would mean either players would have to manage items during a game or would have to accept what the server admin set the item slots to. Still, it's possible -- I don't think it would be implemented by TWI though.