PC [1061] Trader time skip doesn't work following a failed partial vote etc

[hunter_hunted]

In the RecieveSkipTraderTimeVote function of KFVoteCollector.uc:

if (PlayersThatHaveVoted.Find(PRI) == INDEX_NONE)
{

The PlayersThatHaveVoted array is for kickvotes, it should instead be checking PlayersReadyToSkipTrader here.


Currently, this might allow the same player to be added twice if they were added previously and the vote wasn't successful.

As such, the end of the ShouldSkipTrader function will find more players ready to skip than exist currently and the vote never succeeds:
return PlayersReadyToSkipTrader.length == PRIs.length;

Looking at this, the skip vote might also fail permanently if a player votes and then leaves as they're in the PlayersReadyToSkipTrader array but no longer counted towards the PRI amount.

 

[hegyeri]

It is necessary to have a hotkey vote to skip trader time (escape menu pathetic solution) and if a person has voted, a voting window appears (such as kick voting function)

 

[hunter_hunted]

1062 made a workaround, but it still checks the kickvote list which lets it add individual players multiple times if they vote every wave.
Votes should no longer fail, but they might still succeed unintentionally based on failed votes in previous waves.

2 players
First trader: Player A votes to skip, player B does not vote. Vote does not pass.
Second trader: Player A does not vote, player B votes to skip. Trader skips, despite player A not voting this wave.

 

[hunter_hunted]

1065: trader voting still checks the kickvote list.

RecieveSkipTraderTimeVote checks PlayersThatHaveVoted which is the kickvote list.

I think most of the issues caused by this have been worked around in other ways now, but the original cause is still there.

Foster Parent