Weapon progression bonuses in Classic?

[Proud_God]

As was recently discovered, weapon progression bonuses still have an effect in Classic (see http://forums.tripwireinteractive.co...&postcount=100). The only way to disable weapon progression bonuses is to set the server setting 'Max Weapon Proficiency' on 1, which makes the server custom and unranked.

As shown in the linked post, this is unintended behaviour: weapon stats should all be on level 0 in Classic.

Note that class progression bonuses are not applied in Classic (as it should be).

So the questions are:

• Were you aware that Classic was still using weapon bonuses?
  
• And knowing this, do you still want them to be there?

Please only vote if you care about Classic.

[Lord_Lovat]

I did not know that weapon bonusses were still in effect and I wouldn't mind seeing that removed. Players don't need help from a bonus, but should depend on their own skill.

[=GG= Mr Moe]

I knew you could earn experience/progression.

I was not really aware that those bonuses had an effect in Classic mode.

[Ducky]

The weapon bonus will not be there for classic. Your weapon will be at level 0.

From ROWeapon.uc:

simulated function UpdateWeaponProficiency(ROGameStatsWrite StatsWrite)
{
 local ROGameReplicationInfo ROGRI;
 local float WeaponFocusModifierPercentage;
 ROGRI = ROGameReplicationInfo(WorldInfo.Game.GameReplicationInfo);
 WeaponLevel = StatsWrite.WeaponLevels[InvIndex];
 if ( ROGRI.bDisableProgressionBonuses )
 {
  WeaponProficiencyRecoilModifier = WeaponProficiencyLevelRecoilModifiers[0];
  WeaponProficiencySwayModifier = WeaponProficiencyLevelSwayModifiers[0];
  WeaponProficiencyReloadModifier = WeaponProficiencyLevelReloadModifiers[0];
  WeaponProficiencyZoomInModifier = WeaponProficiencyLevelZoomInModifiers[0];
  WeaponProficiencyMeleeModifier = WeaponProficiencyLevelMeleeModifiers[0];
  WeaponFocusModifierPercentage = 0;
 }
 else
 {
  WeaponProficiencyRecoilModifier = WeaponProficiencyLevelRecoilModifiers[WeaponLevel];
  WeaponProficiencySwayModifier = WeaponProficiencyLevelSwayModifiers[WeaponLevel];
  WeaponProficiencyReloadModifier = WeaponProficiencyLevelReloadModifiers[WeaponLevel];
  WeaponProficiencyZoomInModifier = WeaponProficiencyLevelZoomInModifiers[WeaponLevel];
  WeaponProficiencyMeleeModifier = (2.f - WeaponProficiencyLevelMeleeModifiers[WeaponLevel]);
  WeaponFocusModifierPercentage = ((1.0 - ROPawn(Instigator).GetClassModifier(ROCPM_Focus)) /
   (1.0 - class'ROPawn'.default.CharacterProgressionArray[5].Modifiers[ROCPM_Focus]));
 }
 WeaponProficiencyDDFSettleTransitionDuration = 1.25 + 0.15 * WeaponFocusModifierPercentage;
 WeaponProficiencyDDFFocusBlendRate = 5.0 + 0.5 * WeaponFocusModifierPercentage;
}

The bDisableProgressionBonuses property is set on round init in ROGameInfo. It is set to TRUE for classic mode and FALSE for realism mode. In custom mode it depends on the setting in the web-admin.
Snipped from ROGameInfo.uc:

 // If Realistic or Classic
 if ( RealismLevel == RORL_Realistic || RealismLevel == RORL_Classic )
 {
     if ( RealismLevel == RORL_Classic )
     {
       bDisablePeripheralActionIndicators = true;
       DamageMode = DMG_Hardcore;
       PlayerHitSoundMode = PHS_Low;
       bDisableSpawnOnSquadLeader = true;
       bClassicStaminaAndSprinting = true;
       bStopSprintingWhenExhausted = false;
       bWeaponHandlingClassic = true;
       bNoControlledBreathingZoom = true;
       bClassicWeaponLoadout = true;
       bDisableProgressionBonuses = true;
       bAllowKillCamera = false;
       if ( ROGameInfoCountDown(WorldInfo.Game) != none )
      {
          KillMessageDelay = FClamp(KillMessageDelay, 5.0, 99.0);
      }
      else
      {
          KillMessageDelay = FClamp(KillMessageDelay, 0, 99.0);
      }
      FriendlyPlayerNames = 1;
      CompassMode = CMP_ClassicCompass;
      RoleOverrideMode = ROM_ClassicRoles;
      VehicleMobilityDamageMode=2;
      TankTurretDamageMode=2;
      VehicleCrewDamageMode=2;
      EnemySpottedMode=ROESM_Full;
  }
  else
  {
      DamageMode = DMG_Standard;
      PlayerHitSoundMode = PHS_Medium;
      bDisableSpawnOnSquadLeader = false;
      bClassicStaminaAndSprinting = false;
      bStopSprintingWhenExhausted = false;
      bWeaponHandlingClassic = false;
      bNoControlledBreathingZoom = false;
      bClassicWeaponLoadout = false;
      bDisableProgressionBonuses = false;
      if ( ROGameInfoCountDown(WorldInfo.Game) != none )
      {
          KillMessageDelay = FClamp(KillMessageDelay, 5.0, 15.0);
      }
      else
      {
          KillMessageDelay = FClamp(KillMessageDelay, 0, 15.0);
      }
      FriendlyPlayerNames = Clamp(FriendlyPlayerNames,1,2);
      CompassMode = CMP_MinimapTacViewOnly;
      RoleOverrideMode = ROM_DefaultRoles;
      VehicleMobilityDamageMode = 2;
      TankTurretDamageMode = 1;
      VehicleCrewDamageMode=2;
      EnemySpottedMode=ROESM_Full;
  }

[Cyper]

I was actually not aware of this but to be honest I don't care. I mean, what's in the game and what's not, in what mode, does not matter for me anymore. Ideas are worthless unless applied. Every game has its day. I feel like It's a deadend with no end. I am very excited to see what Rising Storm brings to the table and I really appreciate the RS team's effort. It's that kind of people who continue to lit the fire. I do hope that Classic get's some improvements in Rising Storm which actually COULD be likely. I am must excited to see what and if any improvements is made to Classic, OR, best of all, Realism Mode. From a RO formula point of view, I'd say that it should be removed - completely - at least in my opinion, I'll vote: get rid of it. Skilled players does not need it. Especially not in the better mode such as classic. That's all I have to say and will say about this and I can also hope that all Classic player's get what they want because they deserve it.

[Sarkis.]

Well, somewhere along the way, the bonuses are making their way into Classic. We proved that. And also, if the weapons would be LVL0, why does it show LVL50 in game, when in Classic, or even Custom with Progressions disabled? The weapon bonuses are there, they are real.

Something is happening that: bDisableProgressionBonuses does not affect Weapon Proefiency level (1-50)

[Ducky]

Originally Posted by Sarkis.

--SNIP--
And also, if the weapons would be LVL0, why does it show LVL50 in game, when in Classic, or even Custom with Progressions disabled? The weapon bonuses are there, they are real.
--SNIP--

With that, do you mean in the weapon stats screen or the weapon selection screen?

[Sarkis.]

Weapon Selection Screen, while playing in a Classic server. The bonuses from LVL 50 will still apply in Classic. Even though the unlocks are overridden by Classic Loadouts.

[Ducky]

What's displayed in that screen is the level of your weapons as they are for your account. In game you should still use the weapons without bonus. How did you prove that this isn't the case?

[Sarkis.]

The time it takes for the character to work his bolt, reload, different sway, time to iron sights, and even deployment for MGs. Seeing how they were in a Classic Server, and even setting Sauce's server to Classic Mode, and the felt difference while running the server with Maximum Weapon Proficiency Level = 1. That results in using your weapon with a 0 LVL in the Selection Menu. For example a PPSh41 LVL0, without all the bonuses, but with the drum.

The best way to test this, is to use a LVL 50 or some high value weapon and compare it to a LVL 0 weapons, while in Classic Mode. Say... the K98 sniper that generally will be a low level weapon, and the common K98, a generally high level one. And check their bolting speed. Some bugs present in Classic were also cleared by using Maximum Weapon Proficiency Level = 1. Do I get a medal?

[Ducky]

Originally Posted by Sarkis.

The time it takes for the character to work his bolt, reload, different sway, time to iron sights, and even deployment for MGs. Seeing how they were in a Classic Server, and even setting Sauce's server to Classic Mode, and the felt difference while running the server with Maximum Weapon Proficiency Level = 1. That results in using your weapon with a 0 LVL in the Selection Menu. For example a PPSh41 LVL0, without all the bonuses, but with the drum.

The best way to test this, is to use a LVL 50 or some high value weapon and compare it to a LVL 0 weapons, while in Classic Mode. Say... the K98 sniper that generally will be a low level weapon, and the common K98, a generally high level one. And check their bolting speed. Some bugs present in Classic were also cleared by using Maximum Weapon Proficiency Level = 1. Do I get a medal?

Then I guess you encountered a bug and should report it in the bug report.

[Sarkis.]

RO_Sauce is planning to do that. He understands much more of the bug than I do.

[r5cya]

i'm confused. doesn't Ducky's post show, that bonuses do not have any effect in "classic"?

[Sarkis.]

It was noise only a blind man could hear.

[Proud_God]

Originally Posted by Ducky

Code

I'm going to hazard a guess: maybe that code is not properly executed on both the client and the server?

[Ducky]

Originally Posted by Proud_God

I'm going to hazard a guess: maybe that code is not properly executed on both the client and the server?

Could be. It will take a bit more time to figure out if it's executed properly or not. If it's not, then it's clearly a bug.

Originally Posted by Sarkis.

It was noise only a blind man could hear.

Now that's what I call a remarkable constructive post

This thread is noise too. It's noise about a bug that should be reported in the bug section. If something isn't working as it's being described, then it's called a bug.

Please submit a bug report. That would be really constructive.