PC Stab / bash attack of the melee weapons does less damage than intended

[simplecat]

Category: Code.

Summary: Stab or bash attack of the melee weapons does 25% less damage than it supposed to IF this attack is executed after playing purely horizontal light or heavy strike.

Description:

As it is known, purely horizontal melee strikes (attacks while moving left or right) do no more than 75% and not less than 50% damage than vertical strikes (while moving forward or backward).

However every stab or bash attack shares the same traits and depends of whatever kind of attack was executed prior to it: do forward strike and your next stab will be doing 100% of damage, do horizontal strike and your next stab will be doing only 75% of the damage.

Spoiler!

The entire flow starting from StartFire if pretty complicated to figure but if got it right, KFMeleeHelperWeapon.uc: Process Hitbox Collision -> GetDamageScaleByAngle -> ProcessMeleeHit -> TakeDamage

During GetDamageScaleByAngle its goes through the list of CurrentAttackDir, picks matching damage multiplier and returns it. CurrentAttackDir updates in function BeginMeleeAttack and depends on NextAttackDir variable which is being processed at the very begining of the flow, in KFWeap_MeleeBase's function StartFire(byte FireModeNum)

Spoiler!

simulated function StartFire(byte FireModeNum) // our FireModeNum is 3 which is Bash
{
if( FireModeNum == DEFAULT_FIREMODE || FireModeNum == HEAVY_ATK_FIREMODE ) // this does not happen
{
StartMeleeFire(FireModeNum, MeleeAttackHelper.ChooseAttackDir(), ATK_Normal);
return;
}
if( FireModeNum == BASH_FIREMODE && WeaponFireTypes[FireModeNum] == EWFT_None ) // i believe this doesn't happen either, pretty hard to figure exact meaning of this but for melee weapons WeaponFireTypes[FireModeNum] == EWFT_None is FALSE because WeaponFireTypes[BASH_FIREMODE] is rather = EWFT_Custom
{
StartMeleeFire(FireModeNum, MeleeAttackHelper.ChooseAttackDir(), ATK_Normal);
return;
}

Super.StartFire(FireModeNum);
}

Meaning that for Bash attack ChooseAttackDir() doesn't happen and game does not update NextAttackDir hence does not update CurrentAttackDir. CurrentAttackDir stays the same as it was assigned with during the last Light / Heavy attack.

 

[simplecat]

Old but gold. This still happens.

 

[simplecat]

Old but gold x2.

 

[Kittenmittens]

Has this always been the cause or do you know if this start happening around the time we started trying to address various exploits?

 

[simplecat]

As far as i know there was no major changes on this and it was like that since the beginning. This was also reported before me.

PC - Melee stab/bash inherits previous sideswing damage reduction

A melee stab/bash will do less damage if a sideswing attack was the last regular attack performed: https://youtu.be/6Gv62BxB5jI It seems to not clear the *0.75 reduction until a forwards/backwards attack is performed (or when first equipping the weapon). To reproduce: Equip zweihander on...

forums.tripwireinteractive.com

 

[simplecat]

Update on that:

Ion Thruster's charged attack (R) inherits damage multiplier corresponding to its last swing type:

* If the last swing was overhead or uppercut (W or S attack), the charged attack will do full damage (400)
* But if it was horizontal strike (A or D) then charged attack will do only 50% (200) damage

 

[s5yn3t]

Lmao, now thats one hell of an oversight.

 

[Kittenmittens]

Digging into this. I'll update when I have information to share.

 

[s5yn3t]

So was the dmg bug with ion addressed?
I didn't see any info on it on both of the change logs

 

[simplecat]

It was, for regular attacks too. Kudos to twi.

 

[Kittenmittens]

It was.

Gameplay:

• Fixed an issue which caused some melee weapon swing animations and damage values to not sync up as intended.

Thanks again for the report.

 

[s5yn3t]

Well then. I guess i'm blind.
Cheers

 

[simplecat]

Hate to bump this again, but actually nope.
It was fixed for regular stab attacks of melee weapons but not for Ion Thruster. It still does less damage with the Ultimate Charge if its previous attack was a horizontal swing.

KFMeleeHelperWeapon.uc, BeginMeleeAttack (line 437),

CurrentAttackDir = (CurrentFireMode == BASH_FIREMODE) ? DIR_None : NextAttackDir;

It still threats Ultimate Charge as a last attack type because its CurrentFireMode is CUSTOM_FIREMODE which isn't there