PC Ion Thruster does not get Berserker's damage bonuses for its DOT

[simplecat]

Category: Code

Summary: Every attack of the Ion Thruster sets ZEDs on fire. Damage per tick do not get bonuses from Berserker's skills, even though it looks like it supposed to.

Description: Despite that it clearly states that DOT damage type is on-perk (KFDT_Fire_IonThrusterDoT, ModifierPerkList(0)=class'KFPerk_Berserker')
it does not work because in Berserker's ModifyDamageGiven it requires for DamageCauser to exist in order to advance. And when ZED takes DOT, the DamageCauser is not specified so ModifyDamageGiven does not adjust the damage.

 

[Kittenmittens]

I don't think this was a design decision. Looking into it. However they were likely tested and approved with them behaving this way.

 

[Kittenmittens]

I was absolutely wrong. It is a design decision for Zerk.

Firebug Perk passives and actives modify both the DoT and base damage of the weapon directly. The Berserker only modifies the base damage and not the DoT damage directly. It's because the DoT damage is based off the base damage without any modifiers on top. If the Ion Thruster was upgradeable, then the base damage would change and the DoT damage would go up. However, it is not upgradeable so it won't receive a damage bonus. The Berserker damage bonuses are modifying the base damage, however, they are not changing what the base damage is. The Firebug directly modifies the DoT damage and base damage separately, and the Berserker is not set up that way because DoT damage is not their forte.

The Firebug Perk passives and actives apply to the DoT damage as well. The DoT damage takes whatever the base damage is and deals a fraction of that over time.
The Ion Thruster is set up the same way but the Berserker damage increases do not apply to the DoT damage. They only apply to the base damage so the DoT damage is not influenced by any of the Perk skills and that is intended.
If the Firebug had the Ion Thruster as a Perk weapon (which it did at one point) the damage bonuses do apply to the Ion Thruster because the Firebug damage bonuses apply to both the base and the DoT. Because the Berserker has large damage bonuses applied, it does not apply them to the DoT damage to keep the damage values consistent.

 

[simplecat]

Alright, thanks for clarification. Although it looks pretty complicated from a designer perspective it's way more simple through the eyes of programmer - just a missing parameter for a function.